Skip to content

ci(samples): [Sample Tests 48] Run the sample builds' checks in their own workflow - #6444

Closed
runningcode wants to merge 1 commit into
no/jvm-samples-own-buildfrom
no/samples-checks-workflow
Closed

runningcode wants to merge 1 commit into
no/jvm-samples-own-buildfrom
no/samples-checks-workflow

Conversation

@runningcode

@runningcode runningcode commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

PR Stack (Sample Tests)


📜 Description

A new Samples workflow runs check in each build the SDK build doesn't include. There is one matrix job each for sentry-samples, sentry-samples/sentry-samples-android and sentry-android-integration-tests, with fail-fast: false. Each job uploads its own reports and JUnit summary, the same way the Build job does.

make preMerge is back to just the root check. The checkSamples, checkSampleAndroid and checkIntegrationTests targets that #6392–#6394 added are gone.

format-code.yml and make checkFormat don't change. Spotless also runs as part of each build's check.

💡 Motivation and Context

Until now, #6392–#6394 ran each build's check one after another inside Build Job ubuntu-latest. With its own workflow:

  • A broken sample fails its own check instead of the SDK's Build job.
  • The three builds run in parallel with each other and with the SDK build.
  • The Build job gets shorter.

The trade-off is more total runner minutes. Each job compiles the SDK modules its build depends on, but doesn't run their tests.

Part of the Linear project "Separate sample projects and tests from build." (JAVA-626).

💚 How did you test it?

actionlint passes on the new workflow. The Samples jobs on this PR are the real test.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

The main branch ruleset doesn't require the new Check <build> jobs yet, so for now they don't block merges. Requiring them takes an admin to add them to the ruleset.

#skip-changelog

🤖 Generated with Claude Code

The sample and integration test builds ran their `check` inside the SDK's
Build job via `make preMerge`, one after another. A new Samples workflow
runs each build in its own matrix job, so a broken sample fails its own
check, the builds run in parallel, and the Build job gets shorter.
`preMerge` is back to the root `check`.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@sentry

sentry Bot commented Nov 2, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.62.0 (1) release

⚙️ sentry-android Build Distribution Settings

@runningcode

Copy link
Copy Markdown
Contributor Author

Superseded by #6446, which only covers the Android builds and sits on #6393. The JVM samples (#6394) are on hold.

@runningcode runningcode closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant