Repository navigation
ci(android): Reuse NDK and improve test diagnostics - #2179
Merged
Merged
Conversation
The API 26 / NDK 27 job [1] failed in the CoreCLR preload test while Gradle installed NDK `27.0.12077973`: "Archive is not a ZIP archive". CI had already installed `27.3.13750724`, but the sample hardcoded a different version and triggered an extra download. The rerun [2] passed. Honor `ANDROID_NDK` in the sample, matching the library, to avoid that extra installation. Preserve `27.0.12077973` as the default when unset. [1] https://github.com/getsentry/sentry-native/actions/runs/37479955474/job/112325167794 [2] https://github.com/getsentry/sentry-native/actions/runs/37479955474/job/112343128296
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2179 +/- ##
==========================================
- Coverage 75.48% 75.31% -0.18%
==========================================
Files 103 103
Lines 28089 28089
Branches 5150 5150
==========================================
- Hits 21202 21154 -48
- Misses 5545 5589 +44
- Partials 1342 1346 +4 🚀 New features to boost your workflow:
|
The API 35 jobs [1,2] failed with a missing Mono crash marker and a missing CoreCLR database after reinitialization. Investigation found that the helper ignored its exit-wait result and could lose logcat when `pidof` returned multiple PIDs. Require exit for handled exceptions before checking that no native crash was captured. Make `check_exit` opt-in in that wrapper; native crashes and unhandled exceptions already have positive capture or exception assertions. The API 26 job [3] logged the expected `NullReferenceException` but failed the exit assertion. Reproducing this showed an Android crash dialog keeping the process alive beyond 30 seconds, so requiring exit for that scenario was incorrect. Only apply `logcat --pid` to a single numeric PID, and include logcat when an enabled exit check fails. The original API 35 missing-file failures remain unexplained. [1] https://github.com/getsentry/sentry-native/actions/runs/34113447919/job/101714695713 [2] https://github.com/getsentry/sentry-native/actions/runs/34319297419/job/102362182197 [3] https://github.com/getsentry/sentry-native/actions/runs/37810735969/job/113426600284
jpnurmi
force-pushed
the
jpnurmi/ci/android
branch
from
October 9, 2026 10:38
7b16015 to
51b5bc7
Compare
jpnurmi
changed the title
JoshuaMoelans
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigate & diagnose recent Android CI failures:
ANDROID_NDKto avoid a redundant extra NDK download that can fail: