Repository navigation
Conversation
jpnurmi
added this pull request to stack #2181
October 8, 2026 18:47
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2180 +/- ##
==========================================
- Coverage 75.48% 75.39% -0.10%
==========================================
Files 103 103
Lines 28089 28119 +30
Branches 5150 5158 +8
==========================================
- Hits 21202 21199 -3
- Misses 5545 5587 +42
+ Partials 1342 1333 -9 🚀 New features to boost your workflow:
|
This hardening exposes unfinished crash handling when local unwinding or callbacks fault or stall. It also lets the daemon process completed crashes when IPC notifications are lost. Publish `CRASHING` after saving the original fault context, before local capture and crash callbacks. Keep it separate from `CRASHED` so the daemon does not consume mutable captures or event files. Warn once after the handler timeout and continue waiting for delayed completion. Check shared state after notifications and timeouts, and reread it after parent death.
jpnurmi
force-pushed
the
jpnurmi/ref/native-crashing
branch
from
October 9, 2026 06:37
2571c16 to
98293f1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish an early
CRASHINGstate from the crash handler right after saving the crash context to shared memory but before invoking theon_crashorbefore_sendcallbacks that execute arbitrary user code that may, in the worst case, crash the crash handler.This not only hardens the flow for the upcoming crash-stack unwinding (#2174), but in general, allows the daemon to detect such situations and act accordingly, instead of the app vanishing without any notification, resulting in misleading "Parent process exited without crash" logs.
flowchart TB subgraph app["App / backend"] direction LR READY subgraph handler["Crash handler"] direction LR CRASHING["CRASHING (new)"] -->|"on_crash/before_send"| CRASHED end READY --> handler end subgraph daemon["Crash daemon"] direction LR PROCESSING --> PROCESSED --> CAPTURED --> DONE end app --> daemon style CRASHING stroke:red,stroke-width:2px