Skip to content

chore: Remove ai.monitoring.record_token_usage() - #7553

Merged
alexander-alderman-webb merged 10 commits into
major/3.0from
webb/remove-record-token-usage
Oct 8, 2026
Merged

alexander-alderman-webb merged 10 commits into
major/3.0from
webb/remove-record-token-usage

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Delete the ai.monitoring module.

Issues

Closes #6894

Reminders

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 55393 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 58121 | Pass Rate: 95.31% | Execution Time: 155m 14s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -82606
Passed Tests 📉 -78058
Failed Tests 📈 +1
Skipped Tests 📉 -4549

➕ New Tests (1)

View new tests
  • test_spans_from_multiple_threads[propagate_scope=True]
    • File: tests.integrations.threading.test_threading
    • Status: ❌ Failing

❌ Failed Tests

test_spans_from_multiple_threads[propagate_scope=True]

File: tests.integrations.threading.test_threading
Suite: py3.8-common
Error: AssertionError: assert '84a763fb89baa7bf' == '9306aee2f2d7c7c3' - 9306aee2f2d7c7c3 + 84a763fb89baa7bf

Stack Trace
tests/integrations/threading/test_threading.py:176: in test_spans_from_multiple_threads
    assert span["parent_span_id"] == outer_submit_spans[num].span_id
E   AssertionError: assert '84a763fb89baa7bf' == '9306aee2f2d7c7c3'
E     
E     - 9306aee2f2d7c7c3
E     + 84a763fb89baa7bf

✅ Patch coverage is 100.00%. Project has 2074 uncovered lines.
❌ Project coverage is 89.99%. Comparing base (a8b4d0a) to head (f162ed2).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.29%    89.99%     -0.3%
==========================================
  Files          202       184       -18
  Lines        26625     20717     -5908
  Branches      9926      7172     -2754
==========================================
+ Hits         24039     18643     -5396
- Misses        2586      2074      -512
- Partials      1515      1235      -280

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 6, 2026 15:28
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 6, 2026 15:28
@alexander-alderman-webb

Copy link
Copy Markdown
Contributor Author

I'll inline on master instead so we can deprecate.

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as draft October 7, 2026 13:50
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/remove-record-token-usage branch from 1118982 to 198436b Compare October 8, 2026 09:16
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 8, 2026 09:18
@alexander-alderman-webb
alexander-alderman-webb merged commit 5b26f00 into major/3.0 Oct 8, 2026
145 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/remove-record-token-usage branch October 8, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant