Repository navigation
ref(flask): Drop send_default_pii support - #7700
pabloDeputter wants to merge 6 commits into
Conversation
Codecov Results 📊✅ 57603 passed | ❌ 1 failed | ⏭️ 2729 skipped | Total: 60333 | Pass Rate: 95.48% | Execution Time: 157m 40s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
dc98e6e to
39c640f
Compare
| (event,) = events | ||
|
|
||
| assert event["request"]["data"]["password"] == "[Filtered]" | ||
| assert event["request"]["data"]["password"] == "ohno" |
There was a problem hiding this comment.
I'm not sure whether this is correct behavior...but adding the explicit data_collection={} to sentry_init collects request body including the password.
There was a problem hiding this comment.
I believe in data collection mode, this stuff needs to be scrubbed explicitly in before_send (cc @ericapisani if I'm wrong here)
| (event,) = events | ||
|
|
||
| assert event["request"]["data"]["password"] == "[Filtered]" | ||
| assert event["request"]["data"]["password"] == "ohno" |
There was a problem hiding this comment.
I believe in data collection mode, this stuff needs to be scrubbed explicitly in before_send (cc @ericapisani if I'm wrong here)
e1714ed to
6b7b7d8
Compare
Description
FlaskRequestExtractorinherits fromRequestExtractorwhich still has somesend_default_piibranching, but this will be fixed in Remove send_default_pii from wsgi #7616.Issues
Resolves #7590