feat(boto3): Add S3 extension - #7888
Draft
pabloDeputter wants to merge 16 commits into
Draft
pabloDeputter wants to merge 16 commits into
pabloDeputter wants to merge 16 commits into
Conversation
Contributor
Codecov Results 📊✅ 55547 passed | ❌ 1 failed | ⏭️ 2750 skipped | Total: 58298 | Pass Rate: 95.28% | Execution Time: 149m 4s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
➖ Removed Tests (1)View removed tests
❌ Failed Tests
|
pabloDeputter
force-pushed
the
pablo/boto3-add-s3-extension
branch
from
October 6, 2026 14:53
08ce57f to
c43fff1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the following request/response attributes:
aws.s3.bucket,aws.s3.key,aws.s3.upload_id,aws.s3.copy_source,aws.s3.delete,aws.s3.part_number,http.response.body.size(number of bytes in payload),file.size(represents the total file/object size)Following tests were removed/moved from old
test_s3.py(old boto3 integration only added s3 streaming responses support):test_basic()removed - basically only tests botocore xml parsing behavior; generic span behavior is already tested intest_client.py.test_streaming()/test_streaming_close()removed - behavior is already tested intest_client.pywith mock HTTP server.test_span_origin()removed - overlaps with existing tests.test_omit_url_data_if_parsing_fails()moved totest_client.pyand simplified since it's generic instrumentation.test_breadcrumb()andtest_url_query_data_collection_breadcrumb()moved and combined totest_client.py, once again since it's generic instrumentation.Issues
Resolves #7576