Skip to content

feat(boto3): Add S3 extension - #7888

Draft
pabloDeputter wants to merge 16 commits into
major/3.0from
pablo/boto3-add-s3-extension
Draft

pabloDeputter wants to merge 16 commits into
major/3.0from
pablo/boto3-add-s3-extension

Conversation

@pabloDeputter

@pabloDeputter pabloDeputter commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Description

Adds the following request/response attributes: aws.s3.bucket, aws.s3.key, aws.s3.upload_id, aws.s3.copy_source, aws.s3.delete, aws.s3.part_number, http.response.body.size (number of bytes in payload), file.size (represents the total file/object size)

Following tests were removed/moved from old test_s3.py (old boto3 integration only added s3 streaming responses support):

  • test_basic() removed - basically only tests botocore xml parsing behavior; generic span behavior is already tested in test_client.py.
  • test_streaming() / test_streaming_close() removed - behavior is already tested in test_client.py with mock HTTP server.
  • test_span_origin() removed - overlaps with existing tests.
  • test_omit_url_data_if_parsing_fails() moved to test_client.py and simplified since it's generic instrumentation.
  • test_breadcrumb() and test_url_query_data_collection_breadcrumb() moved and combined to test_client.py, once again since it's generic instrumentation.

Issues

Resolves #7576

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 55547 passed | ❌ 1 failed | ⏭️ 2750 skipped | Total: 58298 | Pass Rate: 95.28% | Execution Time: 149m 4s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -82087
Passed Tests 📉 -77615
Failed Tests —
Skipped Tests 📉 -4472

➕ New Tests (1)

View new tests
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module

❌ Failed Tests

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2072 uncovered lines.
❌ Project coverage is 90.02%. Comparing base (2fe6694) to head (d0394ea).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.38%    90.02%    -0.36%
==========================================
  Files          202       187       -15
  Lines        26552     20766     -5786
  Branches      9858      7160     -2698
==========================================
+ Hits         23997     18694     -5303
- Misses        2555      2072      -483
- Partials      1487      1213      -274

Generated by Codecov Action

@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-add-s3-extension branch from 08ce57f to c43fff1 Compare October 6, 2026 14:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant