Skip to content

tests(aiohttp): Remove redundant empty data_collection from sentry_init #7895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
Oct 7, 2026
Merged

tests(aiohttp): Remove redundant empty data_collection from sentry_init #7895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 9 additions & 36 deletions tests/integrations/aiohttp/test_aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

@pytest.mark.asyncio
async def test_basic(sentry_init, aiohttp_client, capture_events):
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

async def hello(request):
1 / 0
Expand Down Expand Up @@ -74,7 +74,7 @@ async def hello(request):
async def test_post_body_not_read(sentry_init, aiohttp_client, capture_events):
from sentry_sdk.integrations.aiohttp import BODY_NOT_READ_MESSAGE

sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

body = {"some": "value"}

Expand Down Expand Up @@ -102,7 +102,7 @@ async def hello(request):

@pytest.mark.asyncio
async def test_post_body_read(sentry_init, aiohttp_client, capture_events):
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

body = {"some": "value"}

Expand Down Expand Up @@ -232,7 +232,7 @@ async def hello(request):

@pytest.mark.asyncio
async def test_403_not_captured(sentry_init, aiohttp_client, capture_events):
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

async def hello(request):
raise web.HTTPForbidden()
Expand All @@ -253,7 +253,7 @@ async def hello(request):
async def test_cancelled_error_not_captured(
sentry_init, aiohttp_client, capture_events
):
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

async def hello(request):
raise asyncio.CancelledError()
Expand All @@ -276,7 +276,7 @@ async def hello(request):
async def test_half_initialized(sentry_init, aiohttp_client, capture_events):
# Note: the first sentry_init is intentional
sentry_init()
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

async def hello(request):
return web.Response(text="hello")
Expand All @@ -299,7 +299,6 @@ async def test_tracing_unparseable_url(sentry_init, aiohttp_client, capture_item
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -336,7 +335,6 @@ async def test_traces_sampler_gets_request_object_in_sampling_context(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sampler=traces_sampler,
data_collection={},
)

async def kangaroo_handler(request):
Expand Down Expand Up @@ -366,7 +364,6 @@ async def test_has_trace_if_performance_enabled(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -417,7 +414,7 @@ async def hello(request):
async def test_has_trace_if_performance_disabled(
sentry_init, aiohttp_client, capture_events
):
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

async def hello(request):
capture_message("It's a good day to try dividing by 0")
Expand Down Expand Up @@ -453,7 +450,6 @@ async def test_trace_from_headers_if_performance_enabled(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -507,7 +503,7 @@ async def hello(request):
async def test_trace_from_headers_if_performance_disabled(
sentry_init, aiohttp_client, capture_events
):
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
sentry_init(integrations=[AioHttpIntegration()])

async def hello(request):
capture_message("It's a good day to try dividing by 0")
Expand Down Expand Up @@ -678,7 +674,6 @@ async def test_outgoing_trace_headers_adds_missing_unsigned_propagation_headers(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def handler(request):
Expand Down Expand Up @@ -721,7 +716,6 @@ async def test_outgoing_trace_headers_appends_baggage_but_preserves_sentry_trace
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
release="d08ebdb9309e1b004c6f52202de58a09c2268e42",
data_collection={},
)

async def handler(request):
Expand Down Expand Up @@ -755,7 +749,6 @@ async def test_outgoing_trace_headers_preserves_signed_propagation_headers(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def handler(request):
Expand Down Expand Up @@ -795,7 +788,6 @@ async def test_outgoing_trace_headers_preserves_query_signed_baggage(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def handler(request):
Expand Down Expand Up @@ -836,7 +828,6 @@ async def test_request_source_disabled(
traces_sample_rate=1.0,
enable_http_request_source=False,
http_request_source_threshold_ms=0,
data_collection={},
)

# server for making span request
Expand Down Expand Up @@ -887,7 +878,6 @@ async def test_request_source_enabled(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
http_request_source_threshold_ms=0,
data_collection={},
**extra_options,
)

Expand Down Expand Up @@ -931,7 +921,6 @@ async def test_request_source(
traces_sample_rate=1.0,
enable_http_request_source=True,
http_request_source_threshold_ms=0,
data_collection={},
)

# server for making span request
Expand Down Expand Up @@ -992,7 +981,6 @@ async def test_request_source_with_module_in_search_path(
traces_sample_rate=1.0,
enable_http_request_source=True,
http_request_source_threshold_ms=0,
data_collection={},
)

# server for making span request
Expand Down Expand Up @@ -1047,7 +1035,6 @@ async def test_no_request_source_if_duration_too_short(
traces_sample_rate=1.0,
enable_http_request_source=True,
http_request_source_threshold_ms=10**10,
data_collection={},
)

# server for making span request
Expand Down Expand Up @@ -1093,7 +1080,6 @@ async def test_request_source_if_duration_over_threshold(
traces_sample_rate=1.0,
enable_http_request_source=True,
http_request_source_threshold_ms=0,
data_collection={},
)

# server for making span request
Expand Down Expand Up @@ -1152,7 +1138,6 @@ async def test_span_origin(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

# server for making span request
Expand Down Expand Up @@ -1221,9 +1206,7 @@ async def test_failed_request_status_codes(
exception_to_raise,
should_capture,
):
sentry_init(
integrations=[AioHttpIntegration(**integration_kwargs)], data_collection={}
)
sentry_init(integrations=[AioHttpIntegration(**integration_kwargs)])
events = capture_events()

async def handle(_):
Expand Down Expand Up @@ -1259,7 +1242,6 @@ async def test_failed_request_status_codes_with_returned_status(
"""
sentry_init(
integrations=[AioHttpIntegration(failed_request_status_codes={500})],
data_collection={},
)
events = capture_events()

Expand All @@ -1286,7 +1268,6 @@ async def test_failed_request_status_codes_non_http_exception(
"""
sentry_init(
integrations=[AioHttpIntegration(failed_request_status_codes=set())],
data_collection={},
)
events = capture_events()

Expand All @@ -1309,7 +1290,6 @@ async def test_tracing(sentry_init, aiohttp_client, capture_items):
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -1402,7 +1382,6 @@ async def test_sensitive_header_scrubbing(sentry_init, aiohttp_client, capture_i
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -1447,7 +1426,6 @@ async def test_transaction_style(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -1489,7 +1467,6 @@ async def test_http_route(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand All @@ -1513,7 +1490,6 @@ async def test_server_error(sentry_init, aiohttp_client, capture_items):
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -1552,7 +1528,6 @@ async def test_http_exception(sentry_init, aiohttp_client, capture_items):
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -1584,7 +1559,6 @@ async def test_http_exception_ok_status_not_overridden(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def hello(request):
Expand Down Expand Up @@ -1689,7 +1663,6 @@ async def test_outgoing_trace_headers(
sentry_init(
integrations=[AioHttpIntegration()],
traces_sample_rate=1.0,
data_collection={},
)

async def handler(request):
Expand Down
Loading