Skip to content

ci: Pass craft_version to the Craft release action - #6851

Merged
alwx merged 1 commit into
mainfrom
alwx/bugfix/craft-version
Oct 8, 2026
Merged

alwx merged 1 commit into
mainfrom
alwx/bugfix/craft-version

Conversation

@alwx

@alwx alwx commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix

📜 Description

The release workflow now gives craft_version: 2.33.1 to the getsentry/craft action. The version comment on the SHA pin now shows the full version.

💡 Motivation and Context

Craft 2.33.1 uses the action ref as the release tag when craft_version is empty. Our SHA ref has no release binary, so the release job failed: https://github.com/getsentry/sentry-react-native/actions/runs/37757123934

💚 How did you test it?

I parsed the workflow YAML. The fix will be tested by the next release run.

📝 Checklist

  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • No breaking changes.

🔮 Next steps

Dependabot does not update craft_version. Each Craft bump must update it by hand until Craft fixes the version resolution for SHA refs.

🤖 Generated with Claude Code

Craft 2.33.1 uses the action ref as the release tag. A SHA ref has no
release binary, so the release job failed.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • ci: Pass craft_version to the Craft release action by alwx in #6851
  • chore(tracing): Remove unused maxTransactionDurationExceeded span attribute by antonis in #6820
  • fix(core): preserve Hermes internal bytecode frames in Expo by Trancever in #6848
  • chore(core): Re-enable sdk/no-regexp-constructor lint rule by antonis in #6841
  • chore(deps): update Android SDK to v8.60.0 by github-actions in #6850
  • chore(deps): update Cocoa SDK to v9.30.1 by github-actions in #6849
  • feat(core): Report cellular network technology by alwx in #6827
  • test(e2e): Re-enable iOS view_names assertion in captureMessage test by antonis in #6846
  • fix(core): Strip callback options before the native SDK starts by alwx in #6847
  • fix(android): Resolve @sentry/react-native from rootDir in Expo plugin by alwx in #6840
  • chore: Clean up non-actionable TODOs by antonis in #6843
  • chore(deps): update JavaScript SDK to v10.76.0 by antonis in #6831
  • chore(expo): bump sample to Expo 57.0.26 by antonis in #6838
  • chore(deps): Bump basic-ftp to 6.2.2 by alwx in #6837
  • fix(core): Mark package as side-effect free by devclaimjuimperai in #6829
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.31.0 to 2.33.1 by dependabot in #6833
  • chore(deps): bump gradle/actions/setup-gradle from 6.3.0 to 6.4.0 by dependabot in #6834
  • chore(deps): bump getsentry/craft from 2.31.2 to 2.33.1 by dependabot in #6835
  • chore(deps): bump getsentry/github-workflows/validate-pr from 4013fc6e1aeb1be1f9d3b4d232624f0ec1afa613 to 36c729264d2edc29ebae61950c50e1e9f043ad7e by dependabot in #6832
  • fix(android): Settle initNativeReactNavigationNewFrameTracking promise by antonis in #6823
  • fix(spotlight): Forward image attachments to Spotlight by antonis in #6818
  • fix(ios): Prevent crash when initialized with an invalid DSN by antonis in #6825
  • chore(core): Resolve non-actionable TODOs by antonis in #6826
  • chore(core): resolve stale TODO comments by antonis in #6819

Plus 1 more


🤖 This preview updates automatically when you update the PR.

@alwx
alwx marked this pull request as ready for review October 8, 2026 11:53
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 52142bf

@alwx
alwx requested a review from a team October 8, 2026 11:53

@markushi markushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I ran into this as well and we used the same workaround for sentry-java. As an alternative this was fixed in https://github.com/getsentry/craft/releases/tag/2.33.2

@alwx
alwx merged commit 7759d82 into main Oct 8, 2026
67 of 73 checks passed
@alwx
alwx deleted the alwx/bugfix/craft-version branch October 8, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants