Repository navigation
ci: Pass craft_version to the Craft release action - #6851
Merged
Merged
Conversation
Craft 2.33.1 uses the action ref as the release tag. A SHA ref has no release binary, so the release job failed. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
Plus 1 more 🤖 This preview updates automatically when you update the PR. |
alwx
marked this pull request as ready for review
October 8, 2026 11:53
Contributor
markushi
approved these changes
Oct 8, 2026
markushi
left a comment
Member
There was a problem hiding this comment.
LGTM, I ran into this as well and we used the same workaround for sentry-java. As an alternative this was fixed in https://github.com/getsentry/craft/releases/tag/2.33.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The release workflow now gives
craft_version: 2.33.1to thegetsentry/craftaction. The version comment on the SHA pin now shows the full version.💡 Motivation and Context
Craft 2.33.1 uses the action ref as the release tag when
craft_versionis empty. Our SHA ref has no release binary, so the release job failed: https://github.com/getsentry/sentry-react-native/actions/runs/37757123934💚 How did you test it?
I parsed the workflow YAML. The fix will be tested by the next release run.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Dependabot does not update
craft_version. Each Craft bump must update it by hand until Craft fixes the version resolution for SHA refs.🤖 Generated with Claude Code