Repository navigation
Conversation
The "Upload Debug Symbols to Sentry" phase ran `node` to find its script before it loaded `.xcode.env`. When Xcode starts from the Dock, `node` is not on PATH, so the phase skipped the upload or failed the build. Fixes #6859 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ### Fixes | ||
|
|
||
| - Load `ios/.xcode.env` and `ios/.xcode.env.local` in the Expo plugin "Upload Debug Symbols to Sentry" phase before it runs Node, so the phase finds Node when Xcode starts from the Dock ([#6861](https://github.com/getsentry/sentry-react-native/pull/6861)) |
Contributor
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 8.30.0.
Consider moving the entry to the## Unreleasedsection, please.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The Expo plugin "Upload Debug Symbols to Sentry" phase now loads
ios/.xcode.envandios/.xcode.env.localbefore it runs Node. It finds these files the same way as React Nativewith-environment.sh: in$PODFILE_DIR, or else in$PODS_ROOT/...💡 Motivation and Context
The phase ran
nodeto findsentry-xcode-debug-files.shbeforeNODE_BINARYwas set. When Xcode starts from the Dock,nodeis not on PATH, so 7.x skipped the upload and 8.x failed the build. Fixes #6859.💚 How did you test it?
New Jest tests run the generated phase script with
PATH=/usr/bin:/bin:/usr/sbin:/sbinandNODE_BINARYset in.xcode.env.local. Without the fix, the tests fail withnode: command not found, the same error as in the issue.📝 Checklist
sendDefaultPIIis enabled.🤖 Generated with Claude Code