Skip to content

fix(android): Apply screenshot masking options to error and feedback screenshots - #6930

Draft
antonis wants to merge 4 commits into
mainfrom
fix/android-masked-error-screenshots
Draft

antonis wants to merge 4 commits into
mainfrom
fix/android-masked-error-screenshots

Conversation

@antonis

@antonis antonis commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR:

  • Captures screenshots with ScreenshotUtils.takeMaskedScreenshot (sentry-java 8.61.1, feat(android): Add masked screenshot capture for Hybrid SDKs sentry-java#6281), which masks them the same way native error screenshots are masked. If the native options aren't available, no screenshot is taken.
  • Defaults screenshot.maskAllText / maskAllImages to true on Android, as documented. The native Android SDK leaves them off until its next major, and RN only forwarded them when set.
  • Masks react-native-svg views when maskAllImages is on, like Session Replay.
  • Honors <Sentry.Mask> / <Sentry.Unmask> in screenshots when sentry-android-replay is available.

💡 Motivation and Context

Fixes #6900

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

antonis and others added 2 commits October 22, 2026 12:33
…screenshots

Use sentry-java's takeMaskedScreenshot for screenshots captured from JS,
default maskAllText/maskAllImages to true as documented, and honor
Sentry.Mask/Sentry.Unmask when the replay module is available.

Fixes #6900

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • fix(android): Apply screenshot masking options to error and feedback screenshots by antonis in #6930
  • fix(profiling): Drive the native UI profiler from JS by alwx in #6916
  • chore(deps): update Android SDK to v8.61.1 by github-actions in #6929
  • ci: Pin Java 17 for the Android dependency updater by antonis in #6928
  • feat(tracing): Connect React Native traces with embedded WebViews by antonis in #6794
  • refactor(ios): Use internal Cocoa serialization by philprime in #6917
  • chore(deps): update CLI to v3.8.1 by github-actions in #6924
  • chore(deps): update Cocoa SDK to v9.31.0 by github-actions in #6925
  • fix(tracing): Respect enableHTTPTimings and stop leaking HTTP timing listeners by antonis in #6912
  • fix(core): Stop wrapping RNSentry in TurboModuleContext by default by alwx in #6921
  • chore(deps): bump launch-editor from 2.14.1 to 2.14.2 by dependabot in #6922
  • ci: Fix Linux jobs on Ubuntu 26.04 runners by antonis in #6920
  • fix(core): Match Sentry package paths with Windows separators in Metro resolvers by alwx in #6915
  • chore(e2e): Update Expo sample to SDK 58 by antonis in #6914
  • chore(e2e): Bump E2E tests to React Native 0.88.0 by antonis in #6899
  • fix(ios): Find .xcode.env in the debug symbols phase under SwiftPM by alwx in #6911
  • chore(deps): update React Native to v0.88.0 by github-actions in #6903
  • chore(deps): bump getsentry/craft from 2.34.1 to 2.35.0 by dependabot in #6906
  • chore(deps): bump actions/create-github-app-token from 3.2.0 to 3.3.0 by dependabot in #6908
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.33.1 to 2.35.0 by dependabot in #6907
  • chore(sample): Bump React Native sample to 0.88.0 by antonis in #6910
  • chore(deps): bump actions/setup-java from 6.0.1 to 6.1.0 by dependabot in #6909
  • chore(deps): bump the codeql-action group with 3 updates by dependabot in #6905
  • chore(deps): update Sentry Android Gradle Plugin to v6.24.0 by github-actions in #6902

Plus 2 more


🤖 This preview updates automatically when you update the PR.

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Oct 22, 2026
@antonis

antonis commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 551de0b. Configure here.

@antonis
antonis marked this pull request as ready for review October 22, 2026 10:46
@sentry

sentry Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.31.0 (111) Release

⚙️ sentry-react-native Build Distribution Settings

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as blocked and reverting back to draft since the Android bump needs to be reverted for now #6931

@antonis
antonis marked this pull request as draft October 22, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: JS error screenshots ignore screenshot masking options (maskAllText / maskAllImages)

1 participant