Repository navigation
Conversation
RN 0.71's AGP 7.3.1 bundles D8 3.3.83, which crashes dexing sentry-android 8.61.1 (JDK 21 javac writes nameless MethodParameters entries). RN 0.73.11 uses AGP 8.1.1 (D8 8.1.65), which dexes it fine. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
ActiveSupport 7.0's JSON encoder passes `quirks_mode: true`, which json 3.x removed, so `pod install` fails with "unknown keyword: quirks_mode" for any RN Gemfile that keeps activesupport < 7.1 (0.71-0.74), not only RN < 0.72. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
|
Closing for now since we still need test coverage for 0.71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Changes the oldest React Native version in the E2E build matrix from 0.71.19 to 0.73.11, for both iOS and Android. In
.github/workflows/e2e-v2.ymlthis updates the version list, the iOS runnerincludeentry and the threeexcludeentries. The test job only runs 0.88.0 and is unchanged.It also fixes the iOS
pod installfor 0.73. The E2E CLI pinnedjson < 3.0only for RN < 0.72. RN 0.71–0.74 Gemfiles capactivesupport < 7.1, which resolves ActiveSupport 7.0.x. Its JSON encoder passesquirks_mode: true, and json 3.x (3.1.0, released 2026-10-13) no longer accepts that option, sopod installfails withInvalid Podfile file: unknown keyword: quirks_mode. The pin now applies whenever the Gemfile capsactivesupportbelow 7.1 (0.71–0.74; not 0.88).💡 Motivation and Context
The RN 0.71 Android build broke when we bumped to sentry-android 8.61.1 (#6929, reverted in #6931). sentry-java 8.61.1 is compiled with JDK 21. Even without
-parameters, javac 21 writes namelessMethodParametersentries (e.g. for bridge methods), and older D8 versions crash on them:mergeExtDexReleasefailsRN 0.73 is the first version whose default AGP (8.1) handles these jars. With 0.73.11, the E2E matrix can take sentry-android 8.61.1 and later. This raises our oldest tested RN version from 0.71 to 0.73. The declared peer range (
react-native >=0.65.0) is unchanged.We're fixing this in sentry-java separately, so apps on AGP ≤ 8.0 (RN ≤ 0.72) keep working.
💚 How did you test it?
Locally, with the E2E CLI, as CI runs it (
RN_VERSION=0.73.11 ./dev-packages/e2e-tests/cli.mjs android --create --build, JDK 17, release build):BUILD SUCCESSFUL.:app:mergeExtDexReleaseran, and the APK'sclasses.dexcontains the 8.61.1 Sentry classes.iOS 0.73.11
createwith Ruby 3.3.0, as in CI:pod installcompletes.pod installfails with the sameunknown keyword: quirks_modeerror as CI.I didn't run the iOS
xcodebuildstep locally; CI covers it through theready-to-mergelabel.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
🤖 Generated with Claude Code