Repository navigation
Conversation
JavaScript SDKs attach `sourcemap` debug images to every event when debug IDs are injected at build time. `DebugImage` had no such variant and no catch-all, so the whole envelope failed to deserialize. Add a `SourceMap` variant for the `sourcemap` type and an untagged `Other` variant that keeps the full object of any unknown image type. Mark the enum `#[non_exhaustive]` so future variants are not breaking. Fixes getsentry#1267
timfish
marked this pull request as ready for review
October 8, 2026 11:57
timfish
changed the title
sourcemap and catch-all variants to DebugImagesourcemap and catch-all variants to DebugImage
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Lgtm in general, deferring official approval & merge until we are ready for the next breaking release (likely within next few months) 🤞
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
+ Coverage 73.81% 74.37% +0.56%
==========================================
Files 64 79 +15
Lines 7538 10048 +2510
==========================================
+ Hits 5564 7473 +1909
- Misses 1974 2575 +601 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript SDKs attach
debug_meta.images[{ "type": "sourcemap", ... }]to every event once a bundler plugin injects debug IDs.DebugImagehad no such variant and no catch-all, soEnvelope::from_slicefailed on the event item and consumers such astauri-plugin-sentrydropped every frontend event.This adds a
SourceMapvariant for thesourcemaptype and an untaggedOther(Map<String, Value>)variant that keeps the full object of any image type the SDK does not know about, so it round-trips unchanged.DebugImageis now#[non_exhaustive]so future variants do not break downstream code again.This is a breaking change for code that matches
DebugImageexhaustively, so it targets the next minor release.Fixes #1267