Repository navigation
Conversation
MathiasVP
force-pushed
the
js-better-nodejs-callback-support
branch
from
October 7, 2026 10:25
28aa544 to
620f2a8
Compare
MathiasVP
marked this pull request as ready for review
October 7, 2026 10:30
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Standard writable hooks and several supported stream inputs or filesystem variants are not modeled correctly.
Review effort: Balanced
Findings: 5
Open (5)
What changed in this PR
Adds Node.js stream data-flow modeling for Readable.from() and piped destinations.
Changes:
- Models readable stream factories, fluent methods, and implicit pipe writes.
- Adds stream pipe flow tests.
- Documents the analysis improvement.
| File | Description |
|---|---|
NodeJSLib.qll |
Adds stream and pipe flow modeling. |
StreamPipeDataFlow.ql |
Defines inline flow assertions. |
StreamPipeDataFlow.expected |
Stores expected test results. |
stream-pipe.js |
Provides stream flow test cases. |
2026-10-07-nodejs-stream-pipe.md |
Adds the change note. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| private EarlyStageNode getAStreamModuleNode() { BuiltinModule<isStream/1>::builtinModule(result) } | ||
|
|
||
| overlay[local?] | ||
| private predicate isFs(string name) { name = "fs" } |
Comment on lines
+788
to
+789
| streamConstructor(base) and | ||
| memberRead(base, "fromWeb", node) |
| DataFlow::Node pred, DataFlow::ContentSet contents, DataFlow::Node succ | ||
| ) { | ||
| exists(ReadableFromCall call | | ||
| pred = call.getArgument(0).flow() and |
Comment on lines
+981
to
+983
| override string getCalleeName() { result = "write" } | ||
|
|
||
| override string getMethodName() { result = "write" } |
|
|
||
| module StreamPipeConfig implements DataFlow::ConfigSig { | ||
| predicate isSource(DataFlow::Node source) { | ||
| source.getFile().getBaseName() = ["stream-pipe.js", "stream-pipe.mjs"] and |
MathiasVP
marked this pull request as draft
October 7, 2026 10:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat vibe-coded, but I think it looks reasonable (after lots of cleanup).