Repository navigation
Unified: Use the shared lib handling of LabeledStmt. - #22768
Open
aschackmull wants to merge 1 commit into
Open
aschackmull wants to merge 1 commit into
aschackmull wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The shared CFG implementation correctly handles enclosing labels through LabeledStmt.getStmt().
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies Unified CFG label handling by delegating labeled statements to the shared control-flow library.
Changes:
- Maps
LabeledStmtdirectly to the Unified AST type. - Limits
hasLabelto labels directly attached to AST nodes.
| File | Description |
|---|---|
unified/ql/lib/codeql/unified/internal/ControlFlowGraph.qll |
Uses shared CFG handling for nested labeled statements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hvitved
approved these changes
Oct 7, 2026
hvitved
left a comment
hvitved
left a comment
Contributor
There was a problem hiding this comment.
LGTM, do we already have CFG tests for labeled statements?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor simplification now that the shared CFG lib knows about labeled statementst.