Repository navigation
Conversation
The canonical representative for this content is `ArrayElement[n!]`, which is why reverse-encoding fails to parse `Member[n]`, but this token needs to work for consistency with API graphs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused parser change correctly handles numeric members and includes representative regression coverage.
0 open findings
What changed in this PR
Fixes JavaScript flow-summary parsing for numeric Member[n] tokens by decoding them as exact property content.
Changes:
- Adds fallback decoding for numeric member tokens.
- Adds Map constructor and iteration flow coverage.
- Updates the consistency-test baseline.
| File | Description |
|---|---|
FlowSummaryPrivate.qll |
Decodes non-canonical Member[n] content. |
tst.js |
Tests value flow through a constructed Map. |
DataFlowConsistency.expected |
Records the new test’s consistency output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the root cause of the issue identified in #22781.
When
Member[n]appeared as the input or output in a flow summary, andnis a number in the "max precise array index" range (0..9) it wasn't parsed correctly.The canonical representative for this content is
ArrayElement[n!](!to exclude the unknownArrayElement content), which is why reverse-encoding fails to parseMember[n].