Repository navigation
Conversation
hvitved
force-pushed
the
hvitved-rust-shared-cfg
branch
5 times, most recently
from
November 4, 2026 08:33
8cc8c5e to
e171f3d
Compare
Extract parenthesized expressions and patterns as their inner entities, and update QL consumers and generated schema. Preserve comments and attributes on the unwrapped nodes, with regression tests. Co-authored-by: Copilot App <[email protected]>
Co-authored-by: Copilot App <[email protected]>
Transfer parenthesized expression attributes and references to their unwrapped nodes when upgrading existing databases. Co-authored-by: Copilot App <[email protected]>
Co-authored-by: Copilot App <[email protected]>
Replace Rust's legacy completion and splitting CFG with the shared control-flow framework, and update downstream CFG consumers and tests. Co-authored-by: Copilot App <[email protected]>
hvitved
force-pushed
the
hvitved-rust-shared-cfg
branch
from
November 4, 2026 13:01
e171f3d to
c000f33
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
|
|
||
| private import internal.MacroExprImpl | ||
| import codeql.rust.elements.AnyAttr |
| */ | ||
|
|
||
| private import internal.StructExprImpl | ||
| import codeql.rust.elements.AnyAttr |
|
|
||
| private import codeql.rust.elements.internal.generated.Synth | ||
| private import codeql.rust.elements.internal.generated.Raw | ||
| import codeql.rust.elements.AnyAttr |
|
|
||
| private import codeql.rust.elements.internal.generated.Synth | ||
| private import codeql.rust.elements.internal.generated.Raw | ||
| import codeql.rust.elements.AnyAttr |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust still used its bespoke completion-tree and CFG-splitting implementation, which duplicated infrastructure now shared by other language frontends. This migrates Rust to the common
codeql.controlflow.ControlFlowGraphframework so it can share the same CFG construction, consistency checks, and maintenance path.Approach
Make0/Make1/Make2pipeline while preserving Rust-specific semantics for patterns,match,let-else, loops, value-carryingbreak, and?.injects(...)relation for semantic AST associations.const/staticdeclarations.The generated CFG and basic-block baselines change substantially because the shared framework exposes canonical before, in, after, and conditional-after nodes.