Skip to content

[Copilot Dreams] Avoid incorrect ARM Linux build assumptions #22947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redsun82 merged 1 commit into from
Oct 30, 2026
+2 −3
Merged

[Copilot Dreams] Avoid incorrect ARM Linux build assumptions #22947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/skills/bazel/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,8 @@ the platform string here; use `os.bzl`.

[`codeql_platform_select`](../../../misc/bazel/os.bzl) takes one keyword argument per CodeQL platform: `linux64`,
`linux_arm64`, `osx64` and `win64`. `otherwise` supplies the value for whichever of those you leave unset; it is **not**
a `//conditions:default`. **There is deliberately no fallback from `linux_arm64` to `linux64`.** If you only care about
the OS, use `os_select`, which gives Linux the same value on both architectures and has a `posix` shorthand for the
shared Linux/macOS value.
a `//conditions:default`. If you only care about the OS, use `os_select`, which gives Linux the same value on both

Copilot AI Oct 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Preserve valid ARM Linux choices: The old blanket warning could make Copilot reject a usable Linux value for an ARM Linux build. Macro calls omit an unset ARM-specific branch, leaving the architecture-independent Linux match; rule implementations still reject a missing ARM-specific value.

architectures and has a `posix` shorthand for the shared Linux/macOS value.

In a macro (no `ctx`) it returns a `select()`:

Expand Down
Loading