You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Could you please confirm that isEmptyState is only set after the initial loading/search operation has completed? Otherwise, the new “No results found” message could briefly appear while results are still loading. Once this is confirmed, the change looks good to me.
Could you please confirm that isEmptyState is only set after the initial loading/search operation has completed? Otherwise, the new “No results found” message could briefly appear while results are still loading. Once this is confirmed, the change looks good to me.
Confirmed — isEmptyState is derived only from the already-available filtered arrays after the component has data.
│ Repositories come from generated.json via AppDataProvider, and organizations come from organizations.json, so there isn’t
│ an async loading/search phase here where the empty state could flash before data arrives. The message only appears when
│ the applied search/filter leaves zero matching items. Thanks for checking!
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #550\n\nShow a clear empty state in both filtered lists when no repositories or organizations match the current search or filters.