Maintenance - #483
Merged
Merged
Maintenance#483
Conversation
issyl0
force-pushed
the
pending-cops
branch
from
September 29, 2026 14:19
24d9511 to
b6d6d87
Compare
- These were pretty old: from 2025 and 2023, respectively. - Some of the new cops only exist in later versions, so projects using older versions will fail with "unrecognized cop" if reading the gem's config files.
issyl0
force-pushed
the
pending-cops
branch
from
September 29, 2026 14:30
b6d6d87 to
963f904
Compare
jakebrady5
approved these changes
Sep 29, 2026
| return | ||
| end | ||
|
|
||
| # `many?` is an ActiveSupport extension, but this cop runs without ActiveSupport. |
There was a problem hiding this comment.
I'm not seeing the reference to many? that this comment references 🤔
Member
Author
There was a problem hiding this comment.
The disabled cop just beneath it wants to change the count > 1 to many?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was about time.