Repository navigation
Conversation
clear_internal_storage runs find ... -type f -delete over /sdcard, which also deletes app-private external files under Android/data and Android/obb. That wipes app assets between tasks, e.g. OsmAnd's offline map files and VLC's media library files, so later tasks in those apps fail for environment reasons. Exclude both paths; user-visible files are still cleared.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clear_internal_storagerunsfind ... -type f -deleteover/sdcard. That also deletes app-private external files underAndroid/dataandAndroid/obb. Those directories hold app assets, not user files. For example, OsmAnd keeps its offline map files there, and VLC keeps media library files there. After the first task that clears storage, later OsmAnd and VLC tasks run with missing assets and fail for environment reasons, not agent reasons.This change adds
! -path "*/Android/data/*"and! -path "*/Android/obb/*"to thefindcommand. User-visible files (Download, Documents, DCIM, and so on) are still cleared as before.Testing: on an AndroidWorld emulator, OsmAnd's offline map was gone after a storage clear before this change and is kept after it. Unit tests in
user_data_generation_testpass.