Skip to content

Keep Android/data and Android/obb in clear_internal_storage - #398

Closed
shaochew wants to merge 1 commit into
google-research:mainfrom
shaochew:pr/keep-android-data
Closed

shaochew wants to merge 1 commit into
google-research:mainfrom
shaochew:pr/keep-android-data

Conversation

@shaochew

Copy link
Copy Markdown

clear_internal_storage runs find ... -type f -delete over /sdcard. That also deletes app-private external files under Android/data and Android/obb. Those directories hold app assets, not user files. For example, OsmAnd keeps its offline map files there, and VLC keeps media library files there. After the first task that clears storage, later OsmAnd and VLC tasks run with missing assets and fail for environment reasons, not agent reasons.

This change adds ! -path "*/Android/data/*" and ! -path "*/Android/obb/*" to the find command. User-visible files (Download, Documents, DCIM, and so on) are still cleared as before.

Testing: on an AndroidWorld emulator, OsmAnd's offline map was gone after a storage clear before this change and is kept after it. Unit tests in user_data_generation_test pass.

clear_internal_storage runs find ... -type f -delete over /sdcard, which
also deletes app-private external files under Android/data and
Android/obb. That wipes app assets between tasks, e.g. OsmAnd's offline
map files and VLC's media library files, so later tasks in those apps
fail for environment reasons. Exclude both paths; user-visible files are
still cleared.
@google-cla

google-cla Bot commented Nov 15, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shaochew shaochew closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant