Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
r0g18
force-pushed
the
fix/event-history-escape
branch
from
October 7, 2026 08:53
57df4c1 to
cb0532d
Compare
testcase-event-history renders _formatEvent() through inner-h-t-m-l, and _formatEvent builds that string with JSON.stringify, which does not HTML-encode. Event fields include task_comments, which carries text produced during task execution, so markup in that text becomes live DOM on the testcase detail page. The default CSP allows script-src 'unsafe-inline', so an injected inline event handler runs in the authenticated origin. Escape every dynamic key and value before interpolating them; only the <b> wrappers remain markup.
r0g18
force-pushed
the
fix/event-history-escape
branch
from
October 7, 2026 08:55
cb0532d to
7e11dfc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testcase-event-historyrenders_formatEvent()throughinner-h-t-m-l, and_formatEventbuilds that string withJSON.stringify, which escapes for JavaScript and not for HTML: it leaves<and>untouched. Event fields includetask_comments, which carries text produced during task execution, so markup that ends up in an event becomes live DOM on the testcase detail page. The default CSP allowsscript-src 'unsafe-inline', so an injected inline event handler runs in the authenticated origin.Fixes #5532.
This escapes every dynamic key and value before interpolating them; the
<b>wrappers stay markup, so the rendering is unchanged for ordinary values.Verified by running the repository's real
_formatEventin headless Chrome under the production CSP, withtask_commentsset to<img src=x onerror=...>:{"task_comments": "<img src="x" onerror="...">"}{"task_comments": "<img src=x onerror=...>"}On tests: the only JavaScript test file under
src/clusterfuzz/_internal/tests/appengine/javascripts/isfake_test.js, and I could not find a runner wiring these Polymer components into CI, so I did not add a test that would not run. If you point me at the harness you want this covered by, I will add one.