Skip to content

Detect crashes in CompilationTestHelper independently of the default locale - #6188

Open
kumarprabhashanand wants to merge 1 commit into
google:masterfrom
kumarprabhashanand:fix-6178-locale-independent-crash-detection
Open

kumarprabhashanand wants to merge 1 commit into
google:masterfrom
kumarprabhashanand:fix-6178-locale-independent-crash-detection

Conversation

@kumarprabhashanand

Copy link
Copy Markdown

Fixes #6178

CompilationTestHelper detected compiler crashes by searching for javac's English crash banner, which javac localizes. Under locales such as de_DE, ja_JP, and zh_CN, crashes could go unnoticed.

Use JavacTaskImpl.doCall() and fail on Result.ABNORMAL instead. Preserve the existing OK/ERROR behavior of expectResult() for all other results.

Add regression tests for crash detection across five locales and for SYSERR still being reported as ERROR. The locale test also verifies that Japanese output does not contain the English crash banner.

@google-cla

google-cla Bot commented Oct 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CompilationTestHelper.doTest() passes when the checker fails to initialize and the default locale is German, Japanese, or Chinese

1 participant