Repository navigation
Detect crashes in CompilationTestHelper independently of the default locale - #6188
Open
kumarprabhashanand wants to merge 1 commit into
Open
kumarprabhashanand wants to merge 1 commit into
kumarprabhashanand wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6178
CompilationTestHelperdetected compiler crashes by searching for javac's English crash banner, which javac localizes. Under locales such asde_DE,ja_JP, andzh_CN, crashes could go unnoticed.Use
JavacTaskImpl.doCall()and fail onResult.ABNORMALinstead. Preserve the existing OK/ERROR behavior ofexpectResult()for all other results.Add regression tests for crash detection across five locales and for
SYSERRstill being reported asERROR. The locale test also verifies that Japanese output does not contain the English crash banner.