Repository navigation
fix(test_helpers): allow optional labels on BUG markers in CompilationTestHelper - #6191
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
…nTestHelper In test files using CompilationTestHelper, multiple test cases with identical assertions (such as identical marked lines or repeated markers across test cases) currently report only the line number on failure, requiring the reader to manually open the file and count lines to determine which test case broke. Support an optional label in bug markers, e.g. \// BUG[label]: Diagnostic contains: ...\ or \// BUG[label]: Diagnostic matches: ...\, and include the label alongside the line number in failure reports (\line X [label]\), while preserving full backwards compatibility for unlabeled markers. Fixes google#6144 Signed-off-by: reginaldalfret <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6144.
When test cases in \CompilationTestHelper\ have identical test lines (or repeated assertions across multiple test cases in the same input source), test failure output identifies the failure only by line number, e.g.:
\Did not see an error on line 6 matching Exception created but not thrown.\
When diagnosing failures in CI logs, the reader has to open the test file and count lines to determine which specific scenario or method failed.
Changes
Signed-off-by: reginaldalfret [email protected]