Repository navigation
fix: omit horizontal anchoring for Quick Look wall exports - #5201
Merged
diegoteran merged 1 commit intoOct 9, 2026
Merged
Conversation
Collaborator
|
this is looking good. Do you mind pulling latest changes and resolving merge conflicts? Thanks a lot |
Adopt the wall-export options from the follow-up to google#4030 and test the USDZ metadata, model transforms and viewer rotation. Co-authored-by: Vincent Fretin <[email protected]>
Arthur031221
force-pushed
the
fix-quicklook-wall-placement
branch
from
October 7, 2026 04:57
da5e256 to
6c4d75c
Compare
Contributor
Author
|
Updated the branch on top of current master and resolved the conflicts with the export-failure cleanup. The Chromium AR suite passes with 15 tests passed and one skipped. |
diegoteran
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Related to #3989. Picks up #4030 by @pixlhero, using @vincentfretin's follow-up change in 7d58ce5.
With
ar-placement="wall", the generated USDZ still requests horizontal anchoring. Omit anchoring properties for wall exports, following the approach discussed in #4030. Floor exports retain horizontal anchoring.The regression tests inspect the generated USDZ for a centered cube, an off-center cube, and the original
boom_2_.glbexample. They compare floor and wall transforms with a nonzeroorientation, compare wall exports at two turntable angles, and check the model and viewer state after export. The three new tests fail on the upstream baseline and pass with this change. The Chromium AR suite passed with 15 tests passed and one skipped. TypeScript compilation and the model-viewer production build passed. iOS device testing has not been run.Co-authored-by: Vincent Fretin [email protected]