Repository navigation
feat: improve batching of postgres get queries - #6229
Merged
Merged
Conversation
jess-lowe
approved these changes
Oct 26, 2026
jess-lowe
left a comment
jess-lowe
left a comment
Contributor
There was a problem hiding this comment.
don't fully understand it but seems fine to me
another-rex
reviewed
Oct 26, 2026
| DB: pgPool, | ||
| BatchTimeout: batchTimeout, | ||
| BatchMaxElements: batchMaxElements, | ||
| NormalizeMatchNames: normalizeMatchNames, |
Contributor
There was a problem hiding this comment.
Should we be passing this into the api-devserver as well so we can test that locally?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres testing on test can be a little slow for getting the vulnerability proto / modified dates.
Trying to improve Postgres speed by consolidating the batched gets into a single query, and reducing the batch size.
Still, can be improved a bit more later, by having a Postgres replica in the same region as the API, and avoid de-TOAST-ing the modified dates by having it inline.
Also passes
NormalizeMatchNamesto the Postgres store.