Skip to content

Update org.xhtmlrenderer dependency to flying-saucer-pdf #36

Closed as not planned

Description

@timbonicus

The rendering plugin is using org.xhtmlrenderer:core-renderer:R8, which is rather outdated. I was looking for support of the HTML TITLE tag to set the PDF title, which was added 5 years ago.

It appears the updated dependency is org.xhtmlrenderer:flying-saucer-pdf. Is it possible to get an update to this newer dependency?

Activity

  1. graemerocher commented on Jul 5, 2017

    @graemerocher
    Member

    If I recall I believe the issue is related to licensing and itext changing from GPL to AGPL

  2. mctolentino commented on Jul 28, 2017

    @mctolentino

    Looks like it's safe to update to a newer dependency since flying-saucer-pdf is now using itext 2.1.7 as a dependency:
    https://github.com/flyingsaucerproject/flyingsaucer/blob/master/flying-saucer-pdf/pom.xml

    They've separated the itext5.5 dependent sources:
    https://github.com/flyingsaucerproject/flyingsaucer/tree/master/flying-saucer-pdf-itext5

  3. mctolentino commented on Jul 31, 2017

    @mctolentino

    I've created a pull request with the updated dependencies. I've encountered some issues with Travis, so I also updated some of the build configurations. Can anyone take a look at it? Thanks!

    Pull Request: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions