Repository navigation
feat: add runner-release skill (release cutting + docs alignment), align supported-runner docs - #356
Conversation
- README supported-runners cells now show the newest published engine with its runtime line: CANN vLLM 0.27.1 (9.1) and SGLang 0.5.20 (9.0), CUDA vLLM 0.31.0 (13.0) and SGLang 0.5.21 (13.0), ROCm vLLM 0.31.0 (7.2) and SGLang 0.5.21 (7.2) - historical tables gain the newly published versions at cell head; CANN 9.1 vLLM 0.27.1 carries the (rc) marker for its prerelease vllm-ascend plugin - all 13 published rows cross-checked against the measured catalog (platforms and plugin versions match) Signed-off-by: thxCode <[email protected]>
- new project skill .agents/skills/runner-release: at release time or after Pack publishes images, cross-check published support records against the measured catalog, then align README.md and docs/supported-runners.md - records the rules this alignment follows: published rows only, never invent versions, (rc) marker for CANN prerelease plugins, prune by deletion, Pack owns support-records.md - referenced from AGENTS.md release automation section Signed-off-by: thxCode <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill documentation file for runner-release, registers it in AGENTS.md, and updates the supported runner versions for vLLM and SGLang across several backends in README.md and docs/supported-runners.md. Feedback suggests adding the (rc) label to the CANN vLLM version 0.27.1 in the README.md table to consistently identify it as a prerelease plugin, aligning with the note below the table and the historical records.
Signed-off-by: thxCode <[email protected]>
Signed-off-by: thxCode <[email protected]>
|
Review round triage — 1 item from gemini-code-assist:
No other cells affected: 0.27.1rc1 is the only prerelease plugin among the published records. Verification: |
Normalize the historical tables to break a cell after every two versions, and state the rule in the runner-release skill so future alignment keeps it. Signed-off-by: thxCode <[email protected]>
|
Added 816ebda: the historical tables now wrap every cell after two versions (four cells regrouped), and the runner-release skill states the rule so future alignments keep it. A full-file scan confirms no cell carries more than two versions per line. |
The historical tables are a living document: docs alignment prepends newly published versions and re-wraps cells, so verbatim containment of the legacy fixture cannot hold. Assert the preserved property instead — no original version lost or reordered. Signed-off-by: thxCode <[email protected]>
Every tag release now starts as a pre-release carrying GitHub-generated notes, so an untriaged release never sits public with an empty body. The runner-release skill curates the notes and promotes finals; rc tags stay pre-releases. Signed-off-by: thxCode <[email protected]>
The skill now covers cutting a package release end to end: preflight, version and commit selection against PEP 440 tag shapes, notes drafting, tag push, run monitoring, note curation, and promotion, with PyPI immutability as the hard boundary. AGENTS.md points at both duties. Signed-off-by: thxCode <[email protected]>
|
Scope update, three new commits: 56c8ff9 repairs the auto-sync-contract failure (the support-migration test asserted verbatim containment of the legacy fixture, which a living historical table cannot satisfy — now an ordered-subsequence gate, proven red against a deleted legacy version); 4fe123c makes tag releases publish as pre-releases with generated baseline notes; 4b308b9 extends the runner-release skill with the release-cutting procedure (tag selection, notes, monitor, curate, promote) modeled on the operator release flow. Full auto_sync suite green locally: 811 passed. |
Problem
Two maintainer duties around a release were undocumented or drifted:
Change
(rc)mark for its prerelease plugin); the historical tables gain the newly published versions at cell head, wrapped every two versions.runner-releaseskill with both duties:vX.Y.Z/vX.Y.ZrcN/vX.Y.Z.postN), notes drafting, tag push, run monitoring, note curation, promotion — with PyPI immutability as the hard boundary (a published version is burned; fix forward, never re-tag) and rc tags never promoted.publishedrow against the measured catalog first, then recompute README cells and prepend to historical cells.prerelease: contains(github.ref, 'rc')) let finals go straight to GA with whatever body existed; now every tag release starts as a pre-release with a baseline, and the skill's curate-and-promote step is the gate. PyPI publishes in the same job either way — the gate covers GitHub Release visibility, not the package index.Verification
tests/auto_syncsuite: 811 passed, 17 skipped; the rewritten migration test was confirmed red against a deleted legacy version before going green.lint_workflows.pyonrelease.yml: identical 8 pre-existing shellcheck infos asorigin/main; no new diagnostics.mkdocs build --strictand pre-commit pass on all changed files.publishedrows cross-checked against the catalog (platforms and plugin versions match); post-edit assertions confirmed every published engine heads its historical and README cell.