Repository navigation
Conversation
ZeroID v1.12+ only accepts an id_token exchange from an authenticated, registered client, and requires the ID token to have been issued to that client (aud/azp). codeoid sent its front-door client id "codeoid" with no credentials, so Google sign-in fails against a current ZeroID. The exchange now authenticates as oauth.zeroidClientId (default GOOGLE_CLIENT_ID, override CODEOID_ZEROID_CLIENT_ID) with CODEOID_ZEROID_CLIENT_SECRET (env only). The daemon warns at startup when the secret is missing, and a 401 from ZeroID names the variable. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZeroID v1.12+ only accepts an id_token exchange from an authenticated,
registered client, and requires the ID token to have been issued to
that client (aud/azp). codeoid sent its front-door client id "codeoid"
with no credentials, so Google sign-in fails against a current ZeroID.
The exchange now authenticates as oauth.zeroidClientId (default
GOOGLE_CLIENT_ID, override CODEOID_ZEROID_CLIENT_ID) with
CODEOID_ZEROID_CLIENT_SECRET (env only). The daemon warns at startup
when the secret is missing, and a 401 from ZeroID names the variable.
Deploy step (required before AuthN rolls out ZeroID v1.12.1)
client_id= the Google client id;token_endpoint_auth_method=client_secret_post;CODEOID_ZEROID_CLIENT_SECRETon the codeoid deployment.Against an older ZeroID, the extra credentials are harmless.
oauth.clientId("codeoid") is still codeoid's own front-door client id. Only the upstream exchange changes.Tests
oauth-handler.test.ts:config.test.ts:GOOGLE_CLIENT_ID;bun testpasses (2978 pass, 0 fail), as dotypecheckandbiome check.🤖 Generated with Claude Code