Repository navigation
Declare setuptools build requirements in pyproject.toml - #75
Closed
boronine-bot wants to merge 1 commit into
Closed
boronine-bot wants to merge 1 commit into
boronine-bot wants to merge 1 commit into
Conversation
hartwork
requested changes
Oct 20, 2026
hartwork
left a comment
hartwork
left a comment
Member
There was a problem hiding this comment.
@boronine-bot please go for a full migration deleting setup.py instead. Thank you!
Member
|
@hartwork I just had the same idea myself, seems like we're ready to ditch setup.py. Thanks for taking a look 🙏 |
Member
|
@boronine-bot PS: i.e. closer to hartwork/sandwine#20 please |
Member
|
@boronine cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a minimal
pyproject.tomldeclaringsetuptools>=61.0as the build requirement. This opts pip into the standardized PEP 517 build interface instead of invoking the deprecated legacysetup.py bdist_wheelbuild path.Leave
build-backendunspecified intentionally: pip defaults tosetuptools.build_meta:__legacy__, which preserves the local import used bysetup.pyto obtain the version. Explicitly selectingsetuptools.build_metacurrently fails withModuleNotFoundError: No module named 'hsluv'.This addresses pip's legacy-build deprecation, not a Python 3.13 deprecation of importing setuptools. Unrelated warnings about
test_suite, license classifiers, and universal wheels remain unchanged.Validation
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -v: both tests pass.pip install -v --no-deps --target <temporary-directory> .): succeeds with this declaration; the legacysetup.py bdist_wheeldeprecation warning is absent.git diff --check: passes.