Skip to content

Credit Robert McGinley in package author metadata - #82

Merged
mcginleyr1 merged 2 commits into
hsluv:masterfrom
boronine-bot:docs/credit-robert-mcginley
Oct 20, 2026
Merged

mcginleyr1 merged 2 commits into
hsluv:masterfrom
boronine-bot:docs/credit-robert-mcginley

Conversation

@boronine-bot

@boronine-bot boronine-bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add Robert McGinley to pyproject.toml's author list, matching the names and order already present in the README. Include his email, [email protected], verified against his original Python-port contribution (commit 4ae61f8). Preserve Alexei's name and email.

The README already credits Robert, so no README change is needed. This PR changes only package metadata; the license remains unchanged.

Sebastian's author credit remains in the separate PR #78, which adds him to both lists.

Validation

  • Parsed pyproject.toml with tomllib and compared author names and order against the README: identical.
  • Verified Robert's email matches his original contribution commit and Alexei's email is unchanged.
  • git diff --check: passes.

@boronine
boronine requested a review from mcginleyr1 October 20, 2026 15:34
@boronine

Copy link
Copy Markdown
Member

@mcginleyr1 your call! Hope all is well 🙏

@mcginleyr1

Copy link
Copy Markdown
Contributor

Thanks @boronine ! Hope all is well with you too

@mcginleyr1
mcginleyr1 merged commit cc10ef7 into hsluv:master Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants