Repository navigation
CI green: a video defaults to WebM without MP4, and tests stop assuming one machine - #707
Merged
Merged
Conversation
…ng one machine
CI (Chromium on Linux) has failed on every run. Its browser has no AAC or
H.264 encoder, its fonts differ, and it is slower; eight tests assumed
otherwise, and one failure was the app's.
The app: with no MP4 encoder a video's export defaulted to the first
format, WAV, which drops the picture and fails outright for a video with
no sound ("output configuration is invalid … discarded tracks"). It now
defaults to MP4, or WebM where MP4 cannot be encoded.
The tests:
- export-low-rate-audio (4) and export-to-recents' WAV-to-M4A test need
an AAC encoder; they skip, saying so, where M4A is not offered.
- external-projects: "a stable host is not asked forever" compared two
counts two seconds apart, while a slow machine still had library writes
to come. It now waits for the asking to stop, within twenty seconds.
- search-cramped: the cut-off was asserted at 1070px and 670px, widths
that follow from one machine's fonts. Every width is now held to the
rule itself, 128px of room, and each band to a single cut-off.
- media-posters hovers again when a late redraw removes the card, and
transcript-notice waits for the intro's first commit to land.
Fixes #706
"The Open it button opens the added project" read the current project's entry as soon as the transcript changed, a moment before the session points at the new project; on CI a read in between found no entry. Flaky there (passed on retry), so polled. Refs #706
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI (
ubuntu-latest, Playwright's Chromium) has failed on every recent run. Its browser has no AAC or H.264 encoder, its fonts differ from macOS's, and it is slower. Eight tests assumed otherwise, and one failure was the app's.The app
With no MP4 encoder, a video's export defaulted to the first format in the list, WAV. That drops the picture, and fails outright for a video with no sound: "output configuration is invalid … discarded tracks". A video now defaults to MP4, or to WebM where MP4 can't be encoded. This affects anyone on a Chromium build without proprietary codecs, not only CI.
The tests
export-low-rate-audio(4)export-to-recents— WAV to M4Am4a, gotwavexport-stale-mediaexternal-projects— a stable host is not asked foreversearch-cramped— the cut-offmedia-posters— portrait hover card (flaky)transcript-notice— Save after a failed transcription (flaky)saved.jsonbefore the intro's first commit landedOn macOS nothing skips, so coverage there is unchanged.
Checked
export-stale-mediafails with CI's exact error without the app fix and passes with it; 25 export tests pass and the 5 AAC-dependent ones skip.Fixes #706