Repository navigation
Conversation
Follow-up to iNavFlight#11923: the stick save now ends with the ACTION_SUCCESS sequence. Document which saves sound it, which do not, the DShot beacon caveat and that beeper -ACTION_SUCCESS mutes it.
Contributor
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you |
PR Summary by QodoDocument save-confirmation beeps and silent save paths
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11923.
#11923 made the stick save (
Save setting) end with theACTION_SUCCESSsequence. This adds a paragraph todocs/Controls.mdunder the stick command table that says:Save settingthe FC playsACTION_SUCCESS(two short beeps); a DShot beacon plays only the first, because the second beep falls inside the beacon guard delay (getDShotBeaconGuardDelayUs()).saveConfigAndNotify()sound the same: waypoint mission save (sticks, ConfiguratorMSP_WP_MISSION_SAVE, CLIwp save, MAVLink upload), OSD menu save, end of compass or accelerometer calibration, and flight statistics / servo autotrim saves about 0.5 s after disarm.MSP_EEPROM_WRITE) and CLIsavedo not beep.beeper -ACTION_SUCCESSmutes the confirmation;beeper -MULTI_BEEPSno longer does.docs/Buzzer.md(after #11940) already lists "settings saved" underACTION_SUCCESSand no longer underMULTI_BEEPS, so it needs no change.Docs only, no code change.