Skip to content

cli: fix the comment on the sensor status packing - #12105

Open
Raffi1202 wants to merge 1 commit into
iNavFlight:maintenance-10.xfrom
Raffi1202:fix/cli-status-comment
Open

Raffi1202 wants to merge 1 commit into
iNavFlight:maintenance-10.xfrom
Raffi1202:fix/cli-status-comment

Conversation

@Raffi1202

Copy link
Copy Markdown
Contributor

Follow-up to #11910.

The comment above hardwareSensorStatusName() in src/main/fc/cli.c said that MSP and blackbox pack hardwareSensorStatus_e into two bits. Only blackbox does (hwHealthStatus, blackbox.c:1528); MSP writes each status as a full byte (fc_msp.c:541-544), and MAVLink and OSD compare the values directly (mavlink_streams.c, osd.c:892-901). The comment now says so.

Comment-only, no functional change. SITL builds with -DWARNINGS_AS_ERRORS=ON.

Follow-up to iNavFlight#11910: only blackbox packs hardwareSensorStatus_e into two
bits; MSP, MAVLink and OSD use the value as is. Comment only.
@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Correct CLI comment on hardware sensor status packing

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Clarifies that only blackbox packs hardware sensor statuses into two-bit fields.
• Documents that MSP, MAVLink, and OSD use the status values directly; behavior is unchanged.
High-Level Assessment

Correcting the comment in place is appropriate: it removes the inaccurate claim without changing working code.

Files changed (1) +1 / -1

Documentation (1) +1 / -1
cli.cCorrect the sensor status packing comment +1/-1

Correct the sensor status packing comment

• Clarifies that blackbox packs hardware sensor statuses into two-bit fields, while MSP, MAVLink, and OSD use the values directly. No executable code changes.

src/main/fc/cli.c

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

RAM / Flash usage vs. base commit 9729b2c — commit e88fbf3

Using the nearest available size baseline — the PR's exact base commit has no stored baseline yet.

Target Flash Δ RAM Δ
MATEKF405 +716 B (+0.10%) CCM: +4 B (+0.01%)
RAM: +64 B (+0.06%)
MATEKF722 +300 B (+0.06%) ITCM_RAM: ±0 B (±0.00%)
RAM: +32 B (+0.04%)
TCM: +4 B (+0.02%)
MATEKF765 +708 B (+0.09%) DTCM_RAM: +4 B (+0.01%)
SRAM1: +32 B (+0.03%)
MATEKH743 +876 B (+0.11%) D2_RAM: ±0 B (±0.00%)
DTCM_RAM: +4 B (+0.03%)
ITCM_RAM: ±0 B (±0.00%)
RAM: +32 B (+0.02%)

See RAM/flash optimization guide for techniques to reduce usage.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Test firmware build ready — commit e88fbf3

Download firmware for PR #12105

251 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.

Development build for testing only. Use Full Chip Erase when flashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant