Repository navigation
Conversation
Follow-up to iNavFlight#11910: only blackbox packs hardwareSensorStatus_e into two bits; MSP, MAVLink and OSD use the value as is. Comment only.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you |
PR Summary by QodoCorrect CLI comment on hardware sensor status packing
AI Description
High-Level Assessment
Files changed (1)
|
|
RAM / Flash usage vs. base commit
See RAM/flash optimization guide for techniques to reduce usage. |
|
Test firmware build ready — commit Download firmware for PR #12105 251 targets built. Find your board's
|
Follow-up to #11910.
The comment above
hardwareSensorStatusName()insrc/main/fc/cli.csaid that MSP and blackbox packhardwareSensorStatus_einto two bits. Only blackbox does (hwHealthStatus,blackbox.c:1528); MSP writes each status as a full byte (fc_msp.c:541-544), and MAVLink and OSD compare the values directly (mavlink_streams.c,osd.c:892-901). The comment now says so.Comment-only, no functional change. SITL builds with
-DWARNINGS_AS_ERRORS=ON.