Repository navigation
Export new LMS profiles - #832
Merged
Merged
Conversation
Update the export script, migration/export-crosslink-directory.sql, to export all four new profiles, explicit NCIP versions, namespace handling, bib-ID normalization, and matching pickup behavior. Update the mapping documentation and add export/import regression tests.
adamdickmeiss
requested review from
JanisSaldabols,
jakub-id,
kurtnordstrom and
skomorokh
as code owners
October 27, 2026 11:39
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized mappings match existing profiles and have regression coverage, with no blocking issues identified in static review; tests were not run during this review.
No open issues 🎉
What changed in this PR
Updates the mod-rs Directory exporter to support Evergreen, Horizon, Polaris, and Symphony with settings matching their CrossLink profiles.
Changes:
- Adds LMS and catalog profile mappings, explicit NCIP settings, bib-ID normalization, and profile-specific pickup behavior.
- Updates the field-mapping documentation.
- Adds export/import regression tests covering supported profiles, fallback values, pickup variations, and catalog-only configurations.
| File | Description |
|---|---|
migration/export-crosslink-directory.sql |
Exports the new profiles and their protocol and pickup settings. |
migration/export-crosslink-directory-field-mapping.md |
Documents the expanded mappings and explicit settings. |
directory/test/export_host_profiles_test.go |
Tests SQL projections and persistence through Directory import. |
Review effort: Balanced
jakub-id
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the export script, migration/export-crosslink-directory.sql, to export all four new profiles, explicit NCIP versions, namespace handling, bib-ID normalization, and matching pickup behavior.
Update the mapping documentation and add export/import regression tests.