Repository navigation
build: change: run the protocol tests with opp_repl - #1375
Merged
Merged
Conversation
The protocol workflow ran inet_run_protocol_tests, which uses INET's own copy of opp_repl's test framework in python/inet; the two copies drift. The workflow now installs opp_repl from its github_ci branch, with pyyaml for inet-gpl's packetdrill suite, and runs opp_run_protocol_tests --load $INET_ROOT -p inet. INET's inet.opp gives the suites of tests/protocol, the shared tests/protocol/lib and the debug mode. The inet-gpl build and the packetdrill check stay: inet_run_packetdrill is INET's own tool, and the check keeps a broken inet-gpl from turning the packetdrill wrappers into skips. Checked in the GitHub-job container on one debug build, with inet-gpl at d276352: both runners give the same verdict for each of the 824 protocol tests (394 PASS, 50 expected FAIL, 379 unexpected FAIL). The packetdrill check fails there with INET_CRASH (two unused configuration entries), and it also fails on GitHub master before the protocol tests run, so the unexpected failures do not come from this change. Plan: plan/pending/tests-on-opp-repl.md Change: build | behavior.change | - | tests-on-opp-repl
The protocol workflow runs opp_run_protocol_tests, and both runners give the same verdict for each protocol test. The plan records the check and a finding: the packetdrill check fails on master before the protocol tests run. Plan: plan/pending/tests-on-opp-repl.md Change: plan | behavior.change | - | tests-on-opp-repl
levy
force-pushed
the
topic/tests-on-opp-repl-protocol
branch
from
October 26, 2026 15:59
5c5bfbb to
f808a9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protocol workflow still runs
inet_run_protocol_tests, which uses INET's own copy of opp_repl's test framework inpython/inet. The two copies drift, so a developer who runs a protocol test with opp_repl and the CI job can select different tests. This pull request is the second of the series that #1373 started (plan:plan/pending/tests-on-opp-repl.md), and it moves the protocol workflow to opp_repl.The workflow now installs opp_repl from its
github_cibranch, withpyyamlfor inet-gpl's packetdrill suite, and runsopp_run_protocol_tests --load $INET_ROOT -p inet. INET'sinet.oppfrom #1373 gives the suites oftests/protocol, the sharedtests/protocol/liband the debug mode. The inet-gpl build and the packetdrill check stay. Nothing changes in the tests or their expected results.Commits, in reading order
Evidence
Not verified: the GitHub runners. On master, the packetdrill check fails and stops the job before the protocol tests (run 40334828231), so a run of this branch also stops there. The repair of the check is not a part of this series.
🤖 Generated with Claude Code