Repository navigation
Conversation
The documentation wrote each fingerprint command as `opp_run_fingerprint_tests --load $INET_ROOT -p inet ...`. In the INET tree, the two options are not necessary, and they make each example longer. opp_repl c24d2c6 makes a command look for *.opp files in the current folder and then in its parent folders, as git finds its repository. So in each folder of the INET tree a command finds INET's inet.opp, and it finds the project from the current folder. The developer guide explains this once, with the --load $INET_ROOT -p inet form for a folder outside the INET tree, and the other pages use the short form. The comment of inet.opp says the same. The script fingerprinttest_selfdoc and the workflows keep the long form, so that they do not depend on the current folder. Checked in the GitHub-job container with opp_repl c24d2c6: the short form gives the 3 PASS of examples/empty from the INET root with -f, from examples/empty without an option and from tests/fingerprint with -f. In /tmp, the command finds no project without an option, and gives the 3 PASS with --load $INET_ROOT -p inet. Plan: plan/pending/tests-on-opp-repl.md Change: doc | behavior.change | - | tests-on-opp-repl
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation writes each fingerprint command as
opp_run_fingerprint_tests --load $INET_ROOT -p inet .... In the INET tree, the two options are not necessary, and they make each example longer and harder to remember. This pull request explains the rule once and uses the short form, for exampleopp_run_fingerprint_tests -f wireless, on the other pages.The short form works because opp_repl c24d2c6 (now on
mainandgithub_ci) makes a command look for*.oppfiles in the current folder and then in its parent folders, as git finds its repository. So in each folder of the INET tree a command finds INET'sinet.opp, and it finds the project from the current folder; in a subfolder, a command without a filter tests only that subfolder. The developer guide gives the--load $INET_ROOT -p inetform for a folder outside the INET tree. The scripttests/fingerprint/fingerprinttest_selfdocand the workflows keep the long form, so that they do not depend on the current folder.Commits
Evidence
In a podman copy of the GitHub job (ubuntu 24.04, clang 16) with opp_repl c24d2c6, the short form gives the 3 PASS of
examples/emptyfrom the INET root with-f examples/empty, fromexamples/emptywithout an option and fromtests/fingerprintwith-f examples/empty. In/tmp, the command finds no project without an option, and gives the 3 PASS with--load $INET_ROOT -p inet.Not verified: the HTML build of the developer guide and the tutorial (the changes are inside existing paragraphs and code blocks).
🤖 Generated with Claude Code