Repository navigation
The build matrix's final run, and three tests tagged to the mods they need - #2
Merged
Merged
Conversation
… they need CONTEXT-MODELS/data/matrix2-*.tsv: every test in every composition on the finished branch, nothing skipped, on an idle machine; it replaces the discovery run. All nine compositions build. In the shipped set the one failure is the help key's own test, whose mod the shipped set leaves off. What it found, now in mods/catalog.tsv: tracker and object_slot_owner need Archipelago, not only the randomizer, and room_code needs netplay. Two tests sit under a pattern and pass with their mod off (archipelago_logic, net_multiview_client); they are left as found and said so in matrix2-needs.tsv. Co-Authored-By: Mentat (for Corwin; claude-opus-5-5) <[email protected]>
Member
|
=] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final run of the build matrix, after PR #1, and the three catalog fixes it found. One commit (fc40cca).
What the matrix is
tools/mods_matrix.shbuilds the game once per set of mods (the shipped set, each mod off in turn, and all off) and runs every co-op test in each, skipping nothing.tools/mods_needs.pyreads the results against the catalog'stestscolumn: a test that fails with a mod off belongs to that mod, and a build without the mod should skip it.What it found
mods/catalog.tsv:trackerandobject_slot_ownerneed Archipelago, not only the randomizer.room_codeneeds netplay.archipelago_logic,net_multiview_client): they sit under a pattern and pass with their mod off. Nothing breaks; left as found and said so inCONTEXT-MODELS/data/matrix2-needs.tsv.The run replaces the first, partial one (
matrix1-*), which git history keeps.Checked before opening
Every CI step (Linux, Windows, Switch, Archipelago) was run on this branch merged into the current default branch (8711960), in a clean clone, and passed. The mods tests (42) and the recipe check (7) pass.