Repository navigation
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
object-storage-management-web | f88daf1 | Commit Preview URL Branch Preview URL |
Oct 28 2026, 10:34 AM |
jzunigax2
changed the title
jzunigax2
marked this pull request as ready for review
October 27, 2026 10:42
- Added DeleteEntityButton component for confirming deletions. - Integrated deletion capabilities for wholesalers, partners, and sub-accounts. - Updated ManagementSubAccountDetailPage to conditionally allow deletion based on user role. - Enhanced WholesalersTable and PartnerDetailPage to support deletion actions with appropriate notifications. - Refactored ConfirmActionModal to accept ReactNode for description, improving flexibility.
jzunigax2
force-pushed
the
feat/management-entities-deletion
branch
from
October 28, 2026 10:07
04ca97a to
dd95cb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/internxt/object-storage-server/pull/229, https://github.com/internxt/object-storage-server/pull/230 and https://github.com/internxt/object-storage-server/pull/232
What
Superadmins can now delete sub-accounts, partners and wholesalers from the Management Console. Every delete asks for confirmation first, and staff admins never see the option.
Why
Management needs to be able to delete partners or other entities, currently there is no way to do so from the console.
How
ManagementProvidercalls/management/meonce the user is signed in and exposesisSuperadmin. The check fails closed: staff, legacy env logins and a failed/meall count as not superadmin.deleteSubAccountandgetMe(management.service.ts),deletePartner(partners.service.ts) anddeleteWholesaler(wholesalers.service.ts), each with a unit test.DeleteEntityButton: a new component that holds the button (headerbuttonor table-rowiconvariant) and the confirmation modal. It also exportsEmphasisfor the semibold details.ConfirmActionModal.descriptionnow accepts formatted content as well as plain text. Existing callers that pass a string still work.SubAccountDetailPageis also used by the partner console, so delete is an opt-indeleteSubAccountprop. Only the newManagementSubAccountDetailPagewrapper passes it, and only for superadmins. The partner console is unchanged.