Skip to content

[_]: chore/appy-prettier-format - #165

Merged
larryrider merged 15 commits into
feat/add-ci-husky-prettierfrom
chore/appy-prettier-format
Oct 28, 2026
Merged

larryrider merged 15 commits into
feat/add-ci-husky-prettierfrom
chore/appy-prettier-format

Conversation

@larryrider

Copy link
Copy Markdown
Contributor

Builds on the previous CI/husky/prettier PR: applies the formatting pass that was deferred to keep that PR reviewable, turns on eslint in CI and pre-commit now that the repo is formatted, and fixes everything that surfaced.

  • Apply prettier across the whole codebase (pure formatting, no logic changes).
  • Enable eslint as a blocking step in both the GitHub Action and the pre-commit hook.
  • Fix all real lint errors (~1600 -> 0), each verified not to change behavior:
    • Reordered several const fetchX = ... declarations that were referenced by a useEffect above them (temporal-dead-zone bug, not just style).
    • react-hooks/refs: moved a DOM measurement (Dropdown) to useLayoutEffect, converted a "sticky" ref read during render (SubAccountBucketDetailPage) to useState.
    • react-hooks/incompatible-library: replaced react-hook-form's watch() with useWatch() in 6 forms (the React Compiler-compatible API for the same thing).
    • @typescript-eslint/no-explicit-any: replaced any with real types in 3 files.
    • no-console: removed leftover debug logging (including one that was logging S3 accessKeyId/secretAccessKey to the browser console), wired two swallowed errors up to the existing toast notification pattern instead, kept two DEV-gated non-sensitive diagnostics.
    • react-hooks/exhaustive-deps: wrapped shared fetch functions in useCallback with their real dependencies, stabilized a couple of previously-unstable onClose callback props and a service prop that was a new object every render, and added navigate/getSetup/etc. where they were safely stable. A handful of cases are narrowed on purpose (shared fetch function reused by a debounced search effect, a memoized S3 client), those are annotated inline rather than "fixed" in a way that would've added extra, unwanted requests.
  • react-hooks/set-state-in-effect: kept at error. The ~57 existing call sites got a bare eslint-disable-next-line instead of a rewrite, there is no documented fix for the dominant patterns here (fetch-on-mount, reset state on prop change), confirmed against React's own docs and a tracked upstream issue facebook/react#34743.
  • react-refresh/only-export-components: split the 5 context files (Provider + hook in one module) and 2 utility modules into dedicated files, so each file exports only one kind of thing; rule is back to error.
  • ESLint config: migrated eslint.config.js -> eslint.config.mjs to match the cli repo's structure; bumped @internxt/eslint-config-internxt to 2.1.2 (dropped our max-len override, now redundant with the package's default); removed the now-unused typescript-eslint dependency.
  • Dependency cleanup: moved @internxt/css-config to devDependencies (it's only used by tailwind.config.js); removed 10 packages with zero references anywhere in the codebase, confirmed with knip and manual verification (@stripe/react-stripe-js, @stripe/stripe-js, @tailwindcss/vite, class-variance-authority, history, tw-animate-css, use-debounce, zod, @tailwindcss/postcss, @types/react-router-dom).

@larryrider
larryrider requested review from jzunigax2 and sg-gs October 28, 2026 08:52
@larryrider larryrider self-assigned this Oct 28, 2026
@larryrider
larryrider added this pull request to stack #166 October 28, 2026 08:52
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
object-storage-management-web 3e7e4f1 Commit Preview URL

Branch Preview URL
Oct 28 2026, 08:34 AM

@larryrider
larryrider merged commit 0d35fd5 into main Oct 28, 2026
2 checks passed
@larryrider
larryrider deleted the chore/appy-prettier-format branch October 28, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants