Repository navigation
fix(ci): release workflow installs dev extra + maps; pyyaml in dev extra - #36
Merged
Merged
Conversation
The release job installed bare '-e .' while the test suite (added in py#35) imports interscript.ml.loader, which requires pyyaml at module level. test.yml already needed the maps checkout and INTERSCRIPT_MAPS_PATH; the release workflow now mirrors it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the 0.2.0 release (owner-approved D3, coordinated decode-contract wave).
Root cause of the failed release run:
pip install -e .(bare) whiletests/test_first_alternates.py(added in #35) importsinterscript.ml.loader, which doesimport yamlat module level. Main's test.yml has been red for the same reason.pyproject.toml:pyyaml>=6.0added to thedevextra (it is already a runtime dep of themlextra; tests exercise the loader directly).release.yml: mirrorstest.yml— checks outinterscript/maps, installs.[dev], setsINTERSCRIPT_MAPS_PATH.