Repository navigation
ML runtime: eager rubyzip require + index-v12 default pin - #808
Merged
Merged
Conversation
Model.from_file uses Zip::File but nothing required rubyzip — require "interscript/ml" crashed with NameError on first resolve (found driving the frozen conformance vectors: 12/12 byte-exact once loaded). DEFAULT_INDEX_URL moves from the v10 pin to the current index-v12 (adds urd-diac-base-1.0, urd-g2p-base-1.0, fas-diac-base-1.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two runtime bugs found by driving the frozen conformance vectors (12/12 byte-exact once resolved): Model.from_file crashed on a missing rubyzip require, and the default index pin was v10 — predating the three newest model releases. Re-pin is pure addition.