Repository navigation
ci: the ruby repo's CI tests itself (stale monorepo job removed) - #819
Merged
Merged
Conversation
…moved) The restructure left the rspec job checking out the old monorepo and running ITS corpus specs -- which now enumerate the maps repo and test the new Thai encodings under the monorepo's older runtime (the phasathai failures). A standalone repo tests itself: self-checkout, full spec suite, SKIP_JS/SKIP_PYTHON per the convention. The conformance-matrix job moves into this workflow (it ran on the same triggers).
The byte-decode relabeled invalid sequences as UTF-8; the python reference decodes with errors=replace (U+FFFD). Ruby String#scrub matches byte-for-byte. Caught by the C1 conformance matrix: the invalid bytes crashed first_alternates' split.
CONFORMANCE.md pins the decoder at a 512-step cap; the runtime defaults had drifted (translator 100, byt5 256) truncating long outputs (the fas docs-split rows). The C1 matrix caught it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restructure left the rspec job checking out the old interscript monorepo and running ITS corpus specs. After the Thai encodings merged into the maps repo, that job started failing on the monorepo runtime executing the new maps embedded tests (the phasathai failures) -- cross-repo coupling that the standalone ruby repo should not carry.
The rspec job now checks out THIS repo and runs its own suite (SKIP_JS/SKIP_PYTHON per the convention); the conformance-matrix job consolidates into the same workflow.
Stacks with #816 (equivalence + the C1-shakeout runtime fixes) and #817 (the A4 rulings).