Repository navigation
feat(A4): adopt the strict parse — stray identifiers are a parse error - #828
Merged
Merged
Conversation
The batch-4 hazard (stray identifiers silently no-op — a typo'd map is silently wrong) is closed: the corpus gate passed (295/295 strict-clean after maps#207's stray-'s' fix), so comment_item no longer consumes bare identifiers. The batch-4/5 vectors flip accordingly: - stray identifiers now raise Isc::ParseError (was: silent no-op) - is likewise rejected — the strict parse revealed it only ever executed by accident (noop + the case directive). The sanctioned spelling is the bare stage directive, which the vector now pins. Also fixes the run_rule documentation gap: stdlib functions are stage directives, never run targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the A4 batch-4 hazard under its own gate: the corpus is 295/295 strict-clean (after maps#207's stray-
sfix), so the grammar now rejects stray identifiers instead of silently consuming them.The strict parse also EXPOSED that
run downcaseonly ever executed by accident (noop + case-directive) — the vector now pins the bare stage directive as the sanctioned spelling and expects ParseError forrun <name>.22 vectors green; standardrb clean. Cross-runtime note: the ts/py parsers still tolerate strays — their strict adoption is the follow-up, and the corpus gate guarantees no real map is affected in the interim.