Skip to content

eval: EvalDiac FATHATAN swap fidelity (WO01) - #107

Merged
ronaldtse merged 1 commit into
mainfrom
fix/evaldiac-fathatan-swap
Oct 7, 2026
Merged

ronaldtse merged 1 commit into
mainfrom
fix/evaldiac-fathatan-swap

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

WO01 fidelity check (TODO.sota/01): line-by-line comparison against
Abubakr17/advancing-arabic-diacritization Evaluation/EvalDiac.java.

Normalization tables and letter rules already matched; the port was
missing the cross-letter FATHATAN swap (tanwin here + empty next vs
empty here + tanwin next). Added with unit checks. Noted divergence
kept deliberately: a failed multi-ref word contributes letters once
(max-scoring alternate), not once per attempted alternate — WER is
unaffected either way.

@ronaldtse
ronaldtse merged commit ba1b213 into main Oct 7, 2026
5 checks passed
@ronaldtse
ronaldtse deleted the fix/evaldiac-fathatan-swap branch October 7, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant