Repository navigation
eval: EvalDiac FATHATAN swap fidelity (WO01) - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WO01 fidelity check (TODO.sota/01): line-by-line comparison against
Abubakr17/advancing-arabic-diacritization Evaluation/EvalDiac.java.
Normalization tables and letter rules already matched; the port was
missing the cross-letter FATHATAN swap (tanwin here + empty next vs
empty here + tanwin next). Added with unit checks. Noted divergence
kept deliberately: a failed multi-ref word contributes letters once
(max-scoring alternate), not once per attempted alternate — WER is
unaffected either way.