Repository navigation
fix(ml): re-export firstAlternates through the imf barrel (public surface) - #109
Merged
Merged
Conversation
…rface test npm 5.8.0 shipped tokens.js with firstAlternates but imf/index.ts never re-exported it — the documented import (imf.firstAlternates via 'interscript/ml') was undefined for consumers. ts#108's tests imported source-tree paths, so the gap never surfaced. Patch release follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by post-publish smoke of npm 5.8.0:
imf.firstAlternatesisundefined for consumers —
imf/index.tsre-exports encode/decode/constants from tokens.js but not
firstAlternates, and the exportsmap has no tokens subpath. #108's tests import source-tree paths, so
the gap passed CI.
(
import { imf } from "interscript/ml")Patch release 5.8.1 follows merge.