Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Rejected input transactions cause incorrect BAL indices and hashes.
1 open finding
What changed in this PR
Adds Amsterdam block access list output to t8n and aligns post-Paris finalization with proof-of-stake rules.
Changes:
- Disables block rewards from Paris onward.
- Outputs the BAL, its hash, and gas-limit exception from Amsterdam.
| File | Description |
|---|---|
test/utils/t8n.cpp |
Updates reward handling and Amsterdam BAL result fields. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1758 +/- ##
==========================================
- Coverage 98.16% 98.15% -0.01%
==========================================
Files 184 184
Lines 17078 17097 +19
Branches 3906 3912 +6
==========================================
+ Hits 16764 16782 +18
Misses 234 234
- Partials 80 81 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
From Amsterdam, output the block access list (EIP-7928) and its hash, and report a block exceeding the item bound as BlockException.BLOCK_ACCESS_LIST_GAS_LIMIT_EXCEEDED. A failure of the requests, which are processed before, takes precedence. Pass no block reward from Paris (EIP-3675): a reward of 0 still touches the coinbase, which then is read and lands in the BAL of a block without transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Amsterdam, output the block access list (EIP-7928) and its hash,
and report a block exceeding the item bound as
BlockException.BLOCK_ACCESS_LIST_GAS_LIMIT_EXCEEDED. A failure of the
requests, which are processed before, takes precedence.
Pass no block reward from Paris (EIP-3675): a reward of 0 still touches
the coinbase, which then is read and lands in the BAL of a block
without transactions.