Repository navigation
Use native-bootstrap to find folder for safer natives extraction - #3012
Draft
riccardobl wants to merge 1 commit into
Draft
riccardobl wants to merge 1 commit into
riccardobl wants to merge 1 commit into
Conversation
riccardobl
marked this pull request as draft
October 6, 2026 20:33
jaime-jmebot
approved these changes
Oct 16, 2026
jaime-jmebot
left a comment
jaime-jmebot
left a comment
Contributor
There was a problem hiding this comment.
This refactoring cleanly extracts candidate folder resolution out of NativeLibraryLoader and delegates it to the external native-directories library.
Summary of changes:
- Dependency Updates: Added
native-bootstrap(v0.1.1) andnative-directorieslibrary tolibs.versions.tomlandjme3-desktop/build.gradle. - Code Cleanup: Removed
NativeLibraryExtraction.javaand simplifiedNativeLibraryLoadercandidate folder initialization. - Test Alignment: Updated unit tests to use
NativeDirectoriesand properly manage temporary/cache system properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves out of the repo the code that finds candidate folders for native extraction, so that it can be reused by other native libraries like saferalloc.