Repository navigation
Don't ship tests in the gem - #877
Merged
Merged
Conversation
Bundler's gem template leaves test/ out of spec.files; the tests aren't needed at runtime. spec.test_files is ignored by RubyGems, so it goes too.
Collaborator
|
Nice catch! Thank you. |
Collaborator
|
I have released v1.1.4. Please check it out. |
Contributor
Author
|
Thanks! I confirmed that the package size has gone down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gem currently packs everything
git ls-fileslists, includingtest/(about 90 KB unpacked; 40 KB → 28 KB packed), which isn't needed at runtime and ends up in every installation, e.g. production Docker images.This keeps the gemspec in its Bundler-template shape (per #804) and does what the template does:
test/is rejected fromspec.files.spec.test_filesis removed, as RubyGems ignores it and the template no longer has it.test_filesseems to be deprecated: rubygems/guides#90