Repository navigation
Conversation
virchan
marked this pull request as ready for review
September 30, 2026 05:19
|
|
||
| PKG_CONFIG_PATH=$ABS_PATH/numpy/ pip install . -v --no-build-isolation -Csetup-args=-Dblas=blis | ||
|
|
||
| export CFLAGS=-I$ABS_PATH/BLIS_install/include/blis |
Contributor
There was a problem hiding this comment.
NIT: maybe move CFLAGS under LDFLAGS ? just to keep things tidy? (it doesn't change behaviour of course).
EDIT: and maybe do the same in continuous_integration/install_flexiblas.sh ?
Contributor
|
For completeness: here is the pr that seems to have changed the behaviour on meson-python mesonbuild/meson-python#788 |
Member
|
I haven't read the full discussion but it seems like there is mesonbuild/meson-python#912. I wonder if this is related or a separate thing ... |
Member
|
OK CI is green, let's merge this to get the CI greener! Still a non-deterministic issue IIUC. Thanks for the PR @virchan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259.