Repository navigation
test: verify README Docker persistence command uses /data/ not /mnt/ (#174) - #181
Merged
Merged
Conversation
) Verify that the documented persistence command in README.md configures PERSIST=/data/ and does not reference /mnt/ both via static parsing in readme_quick_start_test.ts and through the full Docker startup harness in docker_persist_test.ts. Closes #174
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #174 reported that the README's persistence command used
PERSIST=/mnt/, causing startup crashes due to/mntpermissions for the non-rootdenouser.Investigation revealed:
d61d8fd) had already updated the README copy-paste command fromPERSIST=/mnt/toPERSIST=/data/, added/dataowned bydenoas aVOLUMEinDockerfile, and defaultedPERSIST=/data/.tests/docker_persist_test.ts.-e PERSIST=/mnt/(an artifact from earlier pre-fix: make Docker persistence path writable by the non-root user (#114) #119 test scripts) rather than using the command documented in the README.tests/readme_quick_start_test.ts(fast unit test without Docker) andtests/docker_persist_test.tsto ensure the README persistence command never regresses to/mnt/and explicitly configures/data/.Closes #174
Evidence
README.mdalready specifiesPERSIST=/data/.docker run ... PERSIST=/data/ ...): starts and listens on0.0.0.0:1991.tests/readme_quick_start_test.ts: passes in 1ms.tests/docker_persist_test.ts: passes with container start, enqueue, recreation, and dequeue.npm run quality:production: passes.Merge Danger
Door: two-way
Blast Radius: test
Test-only additions locking down README documentation invariants. No runtime or dependency changes.